Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 379233003: Revert of Enabled chrome_proxy benchmarks on Android as we now have a TryBot. (Closed)

Created:
6 years, 5 months ago by bolian
Modified:
6 years, 5 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabled chrome_proxy benchmarks on Android as we now have a TryBot. (https://codereview.chromium.org/367753003/) Reason for revert: chrome_proxy tests need live server access. Android chromium.perf bots don't have access to live servers and all tests under tools/perf are now part of chromium.perf. It seems chrome_proxy trybot for now can use flag --also-run-disabled-tests to explicitly run these tests. Original issue's description: > Enabled chrome_proxy benchmarks on Android as we now have a TryBot. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281182 TBR=tonyg@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M tools/perf/benchmarks/chrome_proxy.py View 5 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bolian
Created Revert of Enabled chrome_proxy benchmarks on Android as we now have a TryBot.
6 years, 5 months ago (2014-07-09 19:17:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/379233003/1
6 years, 5 months ago (2014-07-09 19:21:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 19:21:06 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-09 19:21:07 UTC) #4
tonyg
lgtm
6 years, 5 months ago (2014-07-09 21:08:19 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:16:19 UTC) #6
Message was sent while issue was closed.
Change committed as 282123

Powered by Google App Engine
This is Rietveld 408576698