Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/perf/metrics/startup_metric.py

Issue 379233002: Update startup_metric to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/startup_metric.py
diff --git a/tools/perf/metrics/startup_metric.py b/tools/perf/metrics/startup_metric.py
index 1e742ee74024c12ee5222a4453ff9fc046d8ef06..6e6298d702de4f516b7fd95d0346d9ac1d28af40 100644
--- a/tools/perf/metrics/startup_metric.py
+++ b/tools/perf/metrics/startup_metric.py
@@ -9,6 +9,7 @@ from metrics import Metric
from metrics import histogram_util
from telemetry.core import util
+from telemetry.value import scalar
class StartupMetric(Metric):
@@ -84,8 +85,9 @@ class StartupMetric(Metric):
foreground_tab_stats = tab_load_times[0]
foreground_tab_load_complete = ((foreground_tab_stats.load_start_ms +
foreground_tab_stats.load_duration_ms) - browser_main_entry_time_ms)
- results.Add(
- 'foreground_tab_load_complete', 'ms', foreground_tab_load_complete)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'foreground_tab_load_complete', 'ms',
+ foreground_tab_load_complete))
def AddResults(self, tab, results):
get_histogram_js = 'statsCollectionController.getBrowserHistogram("%s")'
@@ -103,7 +105,8 @@ class StartupMetric(Metric):
measured_time = \
(result['buckets'][0]['high'] + result['buckets'][0]['low']) / 2
- results.Add(display_name, 'ms', measured_time)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, display_name, 'ms', measured_time))
# Get tab load times.
browser_main_entry_time_ms = self._GetBrowserMainEntryTime(tab)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698