Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379193004: Fix the build when disable_file_support is set to 1 (Closed)

Created:
6 years, 5 months ago by zhaoze.zhou
Modified:
6 years, 4 months ago
Reviewers:
lgombos, brettw, atreat
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the build when disable_file_support is set to 1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zhaoze.zhou
6 years, 5 months ago (2014-07-14 20:53:37 UTC) #1
lgombos
non-owner looks-good-to-me. net::FileProtocolHandler is available only if DISABLE_FILE_SUPPORT is not defined. It is not clear ...
6 years, 5 months ago (2014-07-14 22:19:57 UTC) #2
zhaoze.zhou
brettw@chromium.org: Please take a look
6 years, 5 months ago (2014-07-17 22:41:40 UTC) #3
brettw
lgtm
6 years, 4 months ago (2014-07-29 21:11:56 UTC) #4
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 4 months ago (2014-07-29 21:13:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/379193004/1
6 years, 4 months ago (2014-07-29 21:15:44 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 03:30:55 UTC) #7
Message was sent while issue was closed. 
Change committed as 286394

Powered by Google App Engine
This is Rietveld 408576698