PlzNavigate: implement RequestNavigation in the no live renderer case

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
+#include "base/time/time.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
+#include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/ssl_status.h"
 
+struct FrameMsg_Navigate_Params;
+
 namespace content {
+class NavigationControllerImpl;
 
 class CONTENT_EXPORT NavigationEntryImpl
     : public NON_EXPORTED_BASE(NavigationEntry) {
  public:
   static NavigationEntryImpl* FromNavigationEntry(NavigationEntry* entry);
 
   // The value of bindings() before it is set during commit.
   static int kInvalidBindings;
 
   NavigationEntryImpl();
@@ skipping 183 matching lines @@
 
   // Indicates which FrameTreeNode to navigate.  Currently only used if the
   // --site-per-process flag is passed.
   int64 frame_tree_node_id() const {
     return frame_tree_node_id_;
   }
   void set_frame_tree_node_id(int64 frame_tree_node_id) {
     frame_tree_node_id_ = frame_tree_node_id;
   }
 
+  // Fills |params| based on the information contained in the entry.
+  void MakeNavigateParams(const NavigationControllerImpl& controller,

[clamy, 2014/07/16 12:13:49]

The code for this function has been moved from navigator_impl.cc because it is
now also used in the unit test introduced by this patch.

[ppi, 2014/07/16 14:28:09]

Could we keep this in Navigator and make it a static method? This way we would
avoid coupling the knowledge of FrameMsg_Navigate_Params with NavigationEntry.

[clamy, 2014/07/16 15:44:53]

Done.

+                          NavigationController::ReloadType reload_type,
+                          base::TimeTicks navigation_start,
+                          FrameMsg_Navigate_Params* params) const;
+
  private:
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
   // Session/Tab restore save portions of this class so that it can be recreated
   // later. If you add a new field that needs to be persisted you'll have to
   // update SessionService/TabRestoreService and Android WebView
   // state_serializer.cc appropriately.
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
 
   // See the accessors above for descriptions.
   int unique_id_;
@@ skipping 106 matching lines @@
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   // Copy and assignment is explicitly allowed for this class.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_