Issue 379123002: Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 379123002: Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode (Closed)

Created:
6 years, 5 months ago by vsevik

Modified:
6 years, 5 months ago

Reviewers:
Vladislav Kaznacheev, pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode (https://codereview.chromium.org/375873002/) Reason for revert: Breaks docked DevTools Original issue's description: > DevTools: enable Screencast in DEBUG_DEVTOOLS mode > > This is useful for debugging Screencast without an Android device. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281755 TBR=pfeldman@chromium.org,kaznacheev@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281990

Patch Set 1 #

Created: 6 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	content/browser/devtools/renderer_overrides_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	content/content_browser.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsevik

Created Revert of DevTools: enable Screencast in DEBUG_DEVTOOLS mode

6 years, 5 months ago (2014-07-09 07:47:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/379123002/1

6 years, 5 months ago (2014-07-09 07:49:04 UTC) #2

Message was sent while issue was closed.

Change committed as 281990

Expand Messages | Collapse Messages