Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/modules/serviceworkers/FetchManager.cpp

Issue 379113002: Move fetch-related predicates to core/fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/FetchManager.cpp
diff --git a/Source/modules/serviceworkers/FetchManager.cpp b/Source/modules/serviceworkers/FetchManager.cpp
index c1e740b2eb548f143e6fa84a4ec6442f97f6073e..d2a10b4faf4d35be4d9175eec7a9dccafcaf2abd 100644
--- a/Source/modules/serviceworkers/FetchManager.cpp
+++ b/Source/modules/serviceworkers/FetchManager.cpp
@@ -10,10 +10,10 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/V8ThrowException.h"
#include "core/dom/ExceptionCode.h"
+#include "core/fetch/CrossOriginAccessControl.h"
#include "core/fileapi/Blob.h"
#include "core/loader/ThreadableLoader.h"
#include "core/loader/ThreadableLoaderClient.h"
-#include "core/xml/XMLHttpRequest.h"
#include "modules/serviceworkers/Response.h"
#include "modules/serviceworkers/ResponseInit.h"
#include "platform/network/ResourceRequest.h"
@@ -177,23 +177,4 @@ void FetchManager::onLoaderFinished(Loader* loader)
m_loaders.remove(loader);
}
-bool FetchManager::isSimpleMethod(const String& method)
-{
- // "A simple method is a method that is `GET`, `HEAD`, or `POST`."
- return isOnAccessControlSimpleRequestMethodWhitelist(method);
-}
-
-bool FetchManager::isForbiddenMethod(const String& method)
-{
- // "A forbidden method is a method that is a byte case-insensitive match for one of `CONNECT`, `TRACE`, and `TRACK`."
- return !XMLHttpRequest::isAllowedHTTPMethod(method);
-}
-
-bool FetchManager::isUsefulMethod(const String& method)
-{
- // "A useful method is a method that is not a forbidden method."
- // "A forbidden method is a method that is a byte case-insensitive match for one of `CONNECT`, `TRACE`, and `TRACK`."
- return XMLHttpRequest::isAllowedHTTPMethod(method);
-}
-
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698