Issue 379083002: Revert of Turn on clang by default on linux, 2nd try.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
awong1

CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, Dai Mikurube (NOT FULLTIME), ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Turn on clang by default on linux, 2nd try. (https://codereview.chromium.org/380573002/) Reason for revert: 32bit bots complain about not finding bits/predef. Examples: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/25814/steps/compile/logs/stdio http://build.chromium.org/p/chromium/builders/Linux/builds/51225 Original issue's description: > Turn on clang by default on linux, 2nd try. > > This is mostly to collect performance and size data for now. Unless things > look really good, I'm going to revert this by wednesday morning (PDT). > > BUG=360311 > TBR=awong@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281914 TBR=awong@chromium.org NOTREECHECKS=true NOTRY=true BUG=360311

Created: 6 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

Created Revert of Turn on clang by default on linux, 2nd try.

6 years, 5 months ago (2014-07-09 04:29:47 UTC) #1

The CQ bit was unchecked by thakis@chromium.org