Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 379073002: Revert of Divorce PaintInvalidationState from LayoutState (https://codereview.chromium.org/36083300… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Correct revert order Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/rendering/LayoutState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 // method would setNeedsRedraw on the GraphicsLayers with invalidations and 1010 // method would setNeedsRedraw on the GraphicsLayers with invalidations and
1011 // let the compositor pick which to actually draw. 1011 // let the compositor pick which to actually draw.
1012 // See http://crbug.com/306706 1012 // See http://crbug.com/306706
1013 void FrameView::invalidateTreeIfNeeded() 1013 void FrameView::invalidateTreeIfNeeded()
1014 { 1014 {
1015 RenderObject* rootForPaintInvalidation = renderView(); 1015 RenderObject* rootForPaintInvalidation = renderView();
1016 ASSERT(!rootForPaintInvalidation->needsLayout()); 1016 ASSERT(!rootForPaintInvalidation->needsLayout());
1017 1017
1018 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInval idation->debugName().ascii()); 1018 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInval idation->debugName().ascii());
1019 1019
1020 PaintInvalidationState rootPaintInvalidationState(*rootForPaintInvalidation) ; 1020 LayoutState rootLayoutState(*rootForPaintInvalidation);
1021 1021
1022 rootForPaintInvalidation->invalidateTreeAfterLayout(rootPaintInvalidationSta te); 1022 rootForPaintInvalidation->invalidateTreeAfterLayout(*rootForPaintInvalidatio n->containerForPaintInvalidation());
1023 1023
1024 // Invalidate the paint of the frameviews scrollbars if needed 1024 // Invalidate the paint of the frameviews scrollbars if needed
1025 if (hasVerticalBarDamage()) 1025 if (hasVerticalBarDamage())
1026 invalidateRect(verticalBarDamage()); 1026 invalidateRect(verticalBarDamage());
1027 if (hasHorizontalBarDamage()) 1027 if (hasHorizontalBarDamage())
1028 invalidateRect(horizontalBarDamage()); 1028 invalidateRect(horizontalBarDamage());
1029 resetScrollbarDamage(); 1029 resetScrollbarDamage();
1030 1030
1031 m_doFullPaintInvalidation = false; 1031 m_doFullPaintInvalidation = false;
1032 } 1032 }
(...skipping 2241 matching lines...) Expand 10 before | Expand all | Expand 10 after
3274 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3274 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3275 { 3275 {
3276 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3276 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3277 if (AXObjectCache* cache = axObjectCache()) { 3277 if (AXObjectCache* cache = axObjectCache()) {
3278 cache->remove(scrollbar); 3278 cache->remove(scrollbar);
3279 cache->handleScrollbarUpdate(this); 3279 cache->handleScrollbarUpdate(this);
3280 } 3280 }
3281 } 3281 }
3282 3282
3283 } // namespace WebCore 3283 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/rendering/LayoutState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698