Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 3790013: Add a test for ConstrainedHtmlUI. (Closed)

Created:
10 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a test for ConstrainedHtmlUI. Linux-only for now. BUG=58022 TEST=included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63102

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A chrome/browser/dom_ui/constrained_html_ui_browsertest.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +4 lines, -0 lines 2 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
10 years, 2 months ago (2010-10-18 22:28:37 UTC) #1
Miranda Callahan
LG with comment change. http://codereview.chromium.org/3790013/diff/1/4 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/3790013/diff/1/4#newcode2109 chrome/chrome_tests.gypi:2109: # TODO(estade): port to win/mac. ...
10 years, 2 months ago (2010-10-18 23:25:59 UTC) #2
Evan Stade
http://codereview.chromium.org/3790013/diff/1/4 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/3790013/diff/1/4#newcode2109 chrome/chrome_tests.gypi:2109: # TODO(estade): port to win/mac. On 2010/10/18 23:26:00, Miranda ...
10 years, 2 months ago (2010-10-18 23:29:07 UTC) #3
Miranda Callahan
10 years, 2 months ago (2010-10-18 23:31:22 UTC) #4
On 2010/10/18 23:29:07, Evan Stade wrote:
> http://codereview.chromium.org/3790013/diff/1/4
> File chrome/chrome_tests.gypi (right):
> 
> http://codereview.chromium.org/3790013/diff/1/4#newcode2109
> chrome/chrome_tests.gypi:2109: # TODO(estade): port to win/mac.
> On 2010/10/18 23:26:00, Miranda Callahan wrote:
> > should probably be against johnnyg/mirandac?
> 
> the name is an indication of authorship, not necessarily responsibility for
> getting it done

ok, LG

Powered by Google App Engine
This is Rietveld 408576698