Issue 378973002: Roll pdfium forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 378973002: Roll pdfium forward. (Closed)

Created:
6 years, 5 months ago by aarya

Modified:
6 years, 5 months ago

Reviewers:
palmer, jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll pdfium forward. TBR=palmer@chromium.org,jam@chromium.org

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aarya

This is to uptake https://pdfium.googlesource.com/pdfium/+/3522876d5291922ddc62bf1b70d02743b0850673 Custom Allocator removal change.

6 years, 5 months ago (2014-07-08 23:11:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aarya@google.com/378973002/1

6 years, 5 months ago (2014-07-08 23:13:08 UTC) #3

Lei Zhang

It's going to fail because the GN trybot is broken. Also, I just landed a ...

6 years, 5 months ago (2014-07-08 23:48:53 UTC) #5

aarya

6 years, 5 months ago (2014-07-08 23:52:17 UTC) #6

Message was sent while issue was closed.

On 2014/07/08 23:48:53, Lei Zhang wrote:
> It's going to fail because the GN trybot is broken. Also, I just landed a
change
> for pkasting that makes things complicated. :\

Closing CL. Lei plans to roll pdfium in
https://codereview.chromium.org/374233003/ after fixing bots.

Expand Messages | Collapse Messages