Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 378943004: cc: Fix slow LayerTreeHostAnimationTest (Closed)

Created:
6 years, 5 months ago by ajuma
Modified:
6 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Fix slow LayerTreeHostAnimationTest This fixes LayerTreeHostAnimationTestAnimationsAddedToNewAndExistingLayers whose single-thread versions were taking 4 seconds, since they couldn't finish until there were no longer any running animations (in single-thread mode, having running animations means continually having pending commits). This removes the running animations, allowing the test to finish. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282051

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +12 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
ajuma
The single-thread versions of this test now run in < 10ms locally. https://codereview.chromium.org/378943004/diff/1/cc/trees/layer_tree_host_unittest_animation.cc File cc/trees/layer_tree_host_unittest_animation.cc ...
6 years, 5 months ago (2014-07-09 14:23:54 UTC) #1
danakj
Thanks a lot! LGTM
6 years, 5 months ago (2014-07-09 15:31:19 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-09 15:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/378943004/1
6 years, 5 months ago (2014-07-09 15:33:10 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 16:03:14 UTC) #5
Message was sent while issue was closed.
Change committed as 282051

Powered by Google App Engine
This is Rietveld 408576698