Issue 378933002: Improve gpu tracing when applying markers directly to gpu target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 378933002: Improve gpu tracing when applying markers directly to gpu target (Closed)

Created:
6 years, 5 months ago by egdaniel

Modified:
6 years, 5 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Improve gpu tracing when applying markers directly to gpu target - Change the debug marker strings sent by the GrGpuGL target to only grab the last object added to the set of active markers. This improves the readability when we end up with a large stack of trace markers. Any trace markers the come from the IODB will continue to be squashed into a single debug marker - Added some more useful, high level markers BUG=skia: Committed: https://skia.googlesource.com/skia/+/d78a168ec2ec2c07c0c1845e6a1781988e4a52d9

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -7 lines)			Patch
M	src/gpu/GrContext.cpp	View	3 chunks	+2 lines, -1 line	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/GrTraceMarker.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrTraceMarker.cpp	View	3 chunks	+21 lines, -4 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	8 chunks	+8 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/378933002/20001

6 years, 5 months ago (2014-07-09 17:30:04 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-09 17:41:32 UTC) #5

Message was sent while issue was closed.

Change committed as d78a168ec2ec2c07c0c1845e6a1781988e4a52d9

Expand Messages | Collapse Messages