Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 378893003: Fix and re-enable "early restart" feature on ChromeOS. (Closed)

Created:
6 years, 5 months ago by Alexander Alekseev
Modified:
6 years, 5 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable "early restart" feature on ChromeOS. 1) Early restart is disabled in "Chrome for ChromeOS" desktop build. 2) Ignore signin profile. The first change simplifies development. The second fixes the problem "user session cannot be ended if both owner and current user both have (different) flags set." BUG=391357 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281989

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Alexander Alekseev
Please review.
6 years, 5 months ago (2014-07-08 18:28:13 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/378893003/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/378893003/diff/1/chrome/browser/chromeos/login/login_utils.cc#newcode124 chrome/browser/chromeos/login/login_utils.cc:124: if (!base::SysInfo::IsRunningOnChromeOS()) FYI we can emulate that at ...
6 years, 5 months ago (2014-07-09 04:04:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/378893003/1
6 years, 5 months ago (2014-07-09 04:07:22 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 05:53:45 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 07:38:01 UTC) #5
Message was sent while issue was closed.
Change committed as 281989

Powered by Google App Engine
This is Rietveld 408576698