DescriptionRevert of Fix Windows logoff race. (https://codereview.chromium.org/349263004/)
Reason for revert:
Suspected as cause of browser_tests failures on Mac10.7 Tests:
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/28572
ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #1):
[ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[10963:519:0708/084058:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (780 ms)
ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #2):
[ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12926:519:0708/084834:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (639 ms)
ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #3):
[ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12935:519:0708/084836:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (551 ms)
ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #4):
[ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12937:519:0708/084837:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (560 ms)
Original issue's description:
> Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels.
> De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run.
> This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak.
>
> TBR=sky@chromium.org, brettw@chromium.org
>
> R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org
> BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281746
TBR=siggi
BUG=392186
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281766
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (0 generated)
|