Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 378863003: Revert of Fix Windows logoff race. (Closed)

Created:
6 years, 5 months ago by maniscalco
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Windows logoff race. (https://codereview.chromium.org/349263004/) Reason for revert: Suspected as cause of browser_tests failures on Mac10.7 Tests: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/28572 ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #1): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [10963:519:0708/084058:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (780 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #2): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12926:519:0708/084834:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (639 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #3): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12935:519:0708/084836:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (551 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #4): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12937:519:0708/084837:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (560 ms) Original issue's description: > Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels. > De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run. > This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak. > > TBR=sky@chromium.org, brettw@chromium.org > > R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org > BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281746 TBR=siggi BUG=392186 NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -196 lines) Patch
M chrome/browser/browser_process_impl.cc View 6 chunks +19 lines, -79 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 11 chunks +44 lines, -105 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
maniscalco
Created Revert of Fix Windows logoff race.
6 years, 5 months ago (2014-07-08 16:17:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/378863003/1
6 years, 5 months ago (2014-07-08 16:19:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 16:19:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 16:19:17 UTC) #4
maniscalco
siggi, I put you on the TBR line.
6 years, 5 months ago (2014-07-08 16:24:07 UTC) #5
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 5 months ago (2014-07-08 16:24:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/378863003/1
6 years, 5 months ago (2014-07-08 16:25:23 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 16:27:18 UTC) #8
Message was sent while issue was closed.
Change committed as 281766

Powered by Google App Engine
This is Rietveld 408576698