Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 378803002: Add a history state update example to key_silk_cases (Closed)

Created:
6 years, 5 months ago by wiltzius
Modified:
6 years, 5 months ago
Reviewers:
nduca, Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a history state update example to key_silk_cases Updating the history state has been a surprisingly rich source of performance bugs. This minimal page exemplifies them. BUG=391158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282291

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved to a local file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M tools/perf/page_sets/key_silk_cases.py View 1 2 chunks +28 lines, -0 lines 0 comments Download
A tools/perf/page_sets/key_silk_cases/pushState.html View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wiltzius
Per Nat's request adding the history state example to key_silk_cases
6 years, 5 months ago (2014-07-08 08:59:20 UTC) #1
Sami
By the way, for really simple pages like this we've just made a local copy ...
6 years, 5 months ago (2014-07-08 11:18:37 UTC) #2
nduca
i'm fine with this being in the wpr, skyostil for the final review, i think ...
6 years, 5 months ago (2014-07-08 23:25:46 UTC) #3
wiltzius
Sigh, one day I'll master branch history.
6 years, 5 months ago (2014-07-09 04:39:18 UTC) #4
Sami
lgtm!
6 years, 5 months ago (2014-07-09 13:07:06 UTC) #5
wiltzius
The CQ bit was checked by wiltzius@chromium.org
6 years, 5 months ago (2014-07-10 02:38:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wiltzius@chromium.org/378803002/20001
6 years, 5 months ago (2014-07-10 02:39:06 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:24:44 UTC) #8
Message was sent while issue was closed.
Change committed as 282291

Powered by Google App Engine
This is Rietveld 408576698