Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/debug.h

Issue 3788008: [Isolates] Fix auto extraction of isolate from heap objects in handle constructor. (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 843
844 // This class is used for entering the debugger. Create an instance in the stack 844 // This class is used for entering the debugger. Create an instance in the stack
845 // to enter the debugger. This will set the current break state, make sure the 845 // to enter the debugger. This will set the current break state, make sure the
846 // debugger is loaded and switch to the debugger context. If the debugger for 846 // debugger is loaded and switch to the debugger context. If the debugger for
847 // some reason could not be entered FailedToEnter will return true. 847 // some reason could not be entered FailedToEnter will return true.
848 class EnterDebugger BASE_EMBEDDED { 848 class EnterDebugger BASE_EMBEDDED {
849 public: 849 public:
850 EnterDebugger() 850 EnterDebugger()
851 : isolate_(Isolate::Current()), 851 : isolate_(Isolate::Current()),
852 prev_(isolate_->debug()->debugger_entry()), 852 prev_(isolate_->debug()->debugger_entry()),
853 has_js_frames_(!it_.done()) { 853 has_js_frames_(!it_.done()),
854 save_(isolate_) {
854 Debug* debug = isolate_->debug(); 855 Debug* debug = isolate_->debug();
855 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(PREEMPT)); 856 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(PREEMPT));
856 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(DEBUGBREAK)); 857 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(DEBUGBREAK));
857 858
858 // Link recursive debugger entry. 859 // Link recursive debugger entry.
859 debug->set_debugger_entry(this); 860 debug->set_debugger_entry(this);
860 861
861 // Store the previous break id and frame id. 862 // Store the previous break id and frame id.
862 break_id_ = debug->break_id(); 863 break_id_ = debug->break_id();
863 break_frame_id_ = debug->break_frame_id(); 864 break_frame_id_ = debug->break_frame_id();
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 1032
1032 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread); 1033 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread);
1033 }; 1034 };
1034 1035
1035 1036
1036 } } // namespace v8::internal 1037 } } // namespace v8::internal
1037 1038
1038 #endif // ENABLE_DEBUGGER_SUPPORT 1039 #endif // ENABLE_DEBUGGER_SUPPORT
1039 1040
1040 #endif // V8_DEBUG_H_ 1041 #endif // V8_DEBUG_H_
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698