Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 3788008: [Isolates] Fix auto extraction of isolate from heap objects in handle constructor. (Closed)

Created:
10 years, 2 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Fix auto extraction of isolate from heap objects in handle constructor. My previous attempt used Handle(T*) and Handle(HeapObject*) overloads, but since T is a class template parameter (and not just a paramer of the constructor) the first signature is preferred when the argument is convertible to T*. This patch exposed an issue with SaveContext which created a handle pointing to NULL context. Bonus: a few lint fixes. Committed: http://code.google.com/p/v8/source/detail?r=5662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -39 lines) Patch
M src/bootstrapper.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/debug.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/debug.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/execution.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/handles.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/handles-inl.h View 1 chunk +9 lines, -6 lines 0 comments Download
M src/heap-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.h View 3 chunks +17 lines, -9 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/string-search.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
10 years, 2 months ago (2010-10-19 12:32:15 UTC) #1
yurys
10 years, 2 months ago (2010-10-19 12:43:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698