Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 378793002: Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, jln (very slow on Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/371113003/) Reason for revert: This seems to be breaking Linux builds: http://build.chromium.org/p/chromium/builders/Linux/builds/51190 http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/26110 Original issue's description: > Disable two yama tests on 3.2 kernels with 32bit userland and 64bit kernel. > > Disabling yama restrictions is broken there. > > BUG=391916 > R=jorgelo@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281666 TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=391916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M sandbox/linux/services/yama_unittests.cc View 3 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nhiroki
Created Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel.
6 years, 5 months ago (2014-07-08 05:54:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/378793002/1
6 years, 5 months ago (2014-07-08 05:55:39 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 05:56:35 UTC) #3
commit-bot: I haz the power
Failed to apply patch for sandbox/linux/services/yama_unittests.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-08 05:56:36 UTC) #4
nhiroki
Reverted this using drover: https://codereview.chromium.org/376793002/
6 years, 5 months ago (2014-07-08 06:05:12 UTC) #5
Nico
6 years, 5 months ago (2014-07-08 15:25:16 UTC) #6
Message was sent while issue was closed.
lgtm, thanks

(could've just added the includes, though)

Powered by Google App Engine
This is Rietveld 408576698