chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc - Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix problems with attaching guest view, add extension function dispatcher Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/guest_view/extension_options/extension_options_apitest.cc » ('j') | chrome/browser/guest_view/extension_options/extension_options_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

index ddf108d5f0ee0b10946361206f0f7054fe079e59..45ddf95b91044bbe32792381104150b709734c12 100644

--- a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

+++ b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

@@ -33,7 +33,9 @@ bool GuestViewInternalCreateGuestFunction::RunAsync() {

const PermissionsData* permissions_data = GetExtension()->permissions_data();

if (!permissions_data->HasAPIPermission(APIPermission::kWebView) &&

- !permissions_data->HasAPIPermission(APIPermission::kAppView)) {

+ !permissions_data->HasAPIPermission(APIPermission::kAppView) &&

+ !permissions_data->HasAPIPermission(

+ APIPermission::kEmbeddedExtensionOptions)) {

Fady Samuel 2014/07/11 21:08:05 This is landing in a few minutes, please update: h

ericzeng 2014/07/14 18:22:32 Done.

LOG(ERROR) << kPermissionRequiredError;

error_ = kPermissionRequiredError;

SendResponse(false);