chrome/renderer/chrome_content_renderer_client.cc - Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kalman's comments, add new test for privileged extension apis Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/extension_options/extension_options_guest.cc ('K') | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc » ('j') | chrome/test/data/extensions/api_test/extension_options/embed_self/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index c49da3c3b6f7019c901da3b18b7da5b7c6d87969..9102c39011958f59a7a97ce7c02bb637746c80e9 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -523,8 +523,9 @@ bool ChromeContentRendererClient::OverrideCreatePlugin(

GetExtensionByOrigin(document.securityOrigin());

if (extension) {

const extensions::APIPermission::ID perms[] = {

- extensions::APIPermission::kAppView,

- extensions::APIPermission::kWebView,

+ extensions::APIPermission::kAppView,

+ extensions::APIPermission::kEmbeddedExtensionOptions,

+ extensions::APIPermission::kWebView,

};

for (size_t i = 0; i < arraysize(perms); ++i) {

if (extension->permissions_data()->HasAPIPermission(perms[i]))