chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kalman's comments, add new test for privileged extension apis Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/extension_options/extension_options_guest.cc ('K') | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/test/data/extensions/api_test/extension_options/embed_self/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 1fccc8f96a8b8ee0acefa71de747fa8a02fc3fe7..fd04c5025e57235a6f4b551712267f625818d6fc 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -63,6 +63,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

PermissionMessage::kIdentityEmail},

{APIPermission::kExperimental, "experimental",

APIPermissionInfo::kFlagCannotBeOptional},

+ {APIPermission::kEmbeddedExtensionOptions, "embeddedExtensionOptions",

+ APIPermissionInfo::kFlagCannotBeOptional},

// NOTE(kalman): this is provided by a manifest property but needs to

// appear in the install permission dialogue, so we need a fake

// permission for it. See http://crbug.com/247857.