Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4913)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.h

Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove WIP test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.h b/chrome/browser/guest_view/extension_options/extension_options_guest.h
new file mode 100644
index 0000000000000000000000000000000000000000..6f1307be6849f72076758c7aa8a204cc13060191
--- /dev/null
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_H_
+#define CHROME_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_H_
+
Devlin 2014/07/16 20:55:06 #include "base/macros.h"
ericzeng 2014/07/16 22:27:38 Done.
+#include "chrome/browser/guest_view/guest_view.h"
+#include "extensions/browser/extension_function_dispatcher.h"
Devlin 2014/07/16 20:55:07 #include "url/gurl.h"
ericzeng 2014/07/16 22:27:38 Done.
+
Devlin 2014/07/16 20:55:06 namespace content { class BrowserContext; }
ericzeng 2014/07/16 22:27:38 Done.
+class ExtensionOptionsGuest
+ : public GuestView<ExtensionOptionsGuest>,
+ public extensions::ExtensionFunctionDispatcher::Delegate {
+ public:
+ static const char Type[];
+
+ ExtensionOptionsGuest(content::BrowserContext* browser_context,
+ int guest_instance_id);
+
+ // GuestViewBase implementation
Devlin 2014/07/16 20:55:06 these need periods at the end (like line 34 has).
ericzeng 2014/07/16 22:27:38 Done.
+ virtual bool CanEmbedderUseGuestView(
+ const std::string& embedder_extension_id) OVERRIDE;
+ virtual void CreateWebContents(
+ const std::string& embedder_extension_id,
+ int embedder_render_process_id,
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) OVERRIDE;
+ virtual void DidAttachToEmbedder() OVERRIDE;
+ virtual void DidInitialize() OVERRIDE;
+
+ // ExtensionFunctionDispatcher::Delegate implementation
+ virtual content::WebContents* GetAssociatedWebContents() const OVERRIDE;
+
+ // content::WebContentsObserver implementation.
+ virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+ private:
+ virtual ~ExtensionOptionsGuest();
+ void OnRequest(const ExtensionHostMsg_Request_Params& params);
+
+ scoped_ptr<extensions::ExtensionFunctionDispatcher>
+ extension_function_dispatcher_;
+ GURL options_page_;
Devlin 2014/07/16 20:55:06 We probably want this to be DISALLOW_COPY_AND_ASSI
ericzeng 2014/07/16 22:27:38 Done.
+};
+
+#endif // CHROME_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_H_

Powered by Google App Engine
This is Rietveld 408576698