Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7741)

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 378783002: Initial implementation of the <extensionoptions> GuestView tag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle changing attribute values, prevent cross-extension options embedding Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
index eaf3db0f3a42329bef713d6583a24a8a31004acb..69878dbc9c00e6c4cad12f405c87a319cb651071 100644
--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
@@ -34,6 +34,7 @@
#include "extensions/common/permissions/manifest_permission_set.h"
#include "extensions/common/permissions/permission_set.h"
#include "extensions/common/permissions/permissions_data.h"
+#include "extensions/common/switches.h"
#include "extensions/common/url_pattern_set.h"
#include "extensions/renderer/dispatcher.h"
#include "extensions/renderer/native_handler.h"
@@ -238,6 +239,7 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(
// Platform app sources that are not API-specific..
source_map->RegisterSource("appView", IDR_APP_VIEW_JS);
+ source_map->RegisterSource("extensionOptions", IDR_EXTENSION_OPTIONS_JS);
source_map->RegisterSource("tagWatcher", IDR_TAG_WATCHER_JS);
source_map->RegisterSource("webViewInternal",
IDR_WEB_VIEW_INTERNAL_CUSTOM_BINDINGS_JS);
@@ -311,6 +313,16 @@ void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules(
module_system->Require("denyAppView");
}
}
+
+ if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT ||
+ context_type == extensions::Feature::UNBLESSED_EXTENSION_CONTEXT) {
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
Devlin 2014/07/15 18:07:35 nit: This should probably use FeatureSwitch (other
ericzeng 2014/07/15 20:23:55 Done.
+ extensions::switches::kEnableEmbeddedExtensionOptions) &&
+ extension->permissions_data()->HasAPIPermission(
+ extensions::APIPermission::kEmbeddedExtensionOptions)) {
+ module_system->Require("extensionOptions");
+ }
+ }
}
void ChromeExtensionsDispatcherDelegate::OnActiveExtensionsUpdated(

Powered by Google App Engine
This is Rietveld 408576698