Initial implementation of the <extensionoptions> GuestView tag

chrome/browser/guest_view/guest_view_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/guest_view_base.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/guest_view/app_view/app_view_guest.h"
+#include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 #include "chrome/browser/guest_view/guest_view_constants.h"
 #include "chrome/browser/guest_view/guest_view_manager.h"
 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/content_settings.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/event_router.h"
+#include "extensions/common/feature_switch.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 
 using content::WebContents;
 
 namespace {
 
 typedef std::map<WebContents*, GuestViewBase*> WebContentsGuestViewMap;
 static base::LazyInstance<WebContentsGuestViewMap> webcontents_guestview_map =
     LAZY_INSTANCE_INITIALIZER;
 
@@ skipping 105 matching lines @@
 
   // Give the derived class an opportunity to perform additional initialization.
   DidInitialize();
 }
 
 // static
 GuestViewBase* GuestViewBase::Create(
     content::BrowserContext* browser_context,
     int guest_instance_id,
     const std::string& view_type) {
+  // TODO(fsamuel): All these string comparisons are a little inefficient. Maybe
+  // we want a registry of GuestView types in the future.

[Fady Samuel, 2014/07/21 19:44:47]

I've addressed this TODO: https://codereview.chromium.org/409603003/

[ericzeng, 2014/07/22 00:00:55]

Done.

   if (view_type == WebViewGuest::Type) {
     return new WebViewGuest(browser_context, guest_instance_id);
   } else if (view_type == AppViewGuest::Type) {
     if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
         switches::kEnableAppView)) {
       return NULL;
     }
     return new AppViewGuest(browser_context, guest_instance_id);
+  } else if (view_type == ExtensionOptionsGuest::Type) {
+    if (!extensions::FeatureSwitch::embedded_extension_options()->IsEnabled()) {
+      return NULL;
+    }
+    return new ExtensionOptionsGuest(browser_context, guest_instance_id);
   }
   NOTREACHED();
   return NULL;
 }
 
 // static
 GuestViewBase* GuestViewBase::FromWebContents(WebContents* web_contents) {
   WebContentsGuestViewMap* guest_map = webcontents_guestview_map.Pointer();
   WebContentsGuestViewMap::iterator it = guest_map->find(web_contents);
   return it == guest_map->end() ? NULL : it->second;
@@ skipping 199 matching lines @@
     // purpose. Let's self-destruct.
     delete this;
     callback.Run(NULL);
     return;
   }
   InitWithWebContents(embedder_extension_id,
                       embedder_render_process_id,
                       guest_web_contents);
   callback.Run(guest_web_contents);
 }