Initial implementation of the <extensionoptions> GuestView tag

chrome/test/data/extensions/api_test/extension_options/embed_self/test.js

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+chrome.test.runTests([
+  // Tests if the <extensionoptions> guest view is successfully created. This
+  // test expects that the guest options page will add a {'pass': true} property
+  // to every Window and fire the runtime.onMessage event with a short message.
+  function canCreateExtensionOptionsGuest() {
+    var done = chrome.test.listenForever(chrome.runtime.onMessage,
+        function(message, sender, sendResponse) {
+      if (message == 'ready') {
+        sendResponse('canCreateExtensionOptionsGuest');
+

[not at google - send to devlin, 2014/07/21 16:30:43]

nit: no blank line here

[ericzeng, 2014/07/21 17:52:39]

Done.

+      } else if (message == 'hi') {
+        var views = chrome.extension.getViews();
+        chrome.test.assertEq(2, views.length);
+        views.forEach(function(view) {
+          chrome.test.assertTrue(view.pass);
+        });
+        chrome.test.assertEq(chrome.runtime.id, sender.id);
+        document.body.removeChild(extensionoptions);
+        done();
+      }
+    });
+
+    var extensionoptions = document.createElement('extensionoptions');
+    extensionoptions.setAttribute('extension', chrome.runtime.id);
+    document.body.appendChild(extensionoptions);
+  },
+
+  // Tests if the <extensionoptions> guest view can access the chrome.storage
+  // API, a privileged extension API.
+  function guestCanAccessStorage() {
+    var onStorage = false;
+    var onSetCallback = false;
+
+    chrome.test.listenOnce(chrome.storage.onChanged, function(change) {
+      chrome.test.assertEq(42, change.test.newValue);
+    });
+
+    // Listens for messages from the options page.
+    var done = chrome.test.listenForever(chrome.runtime.onMessage,
+        function(message, sender, sendResponse) {
+      // Options page is waiting for a command
+      if (message == 'ready')

[not at google - send to devlin, 2014/07/21 16:30:43]

nits:
- if one block needs braces, they all do.
- move the comments inside the bodies that they apply to.
i.e.

if (message == 'ready') {
  // Options page is waiting for a command.
  sendResponse('getCanAccessStorage');
} else if (message.hasOwnProperty('description')) {
  // Message from the options page containing test data.
  ...
}

[ericzeng, 2014/07/21 17:52:39]

Done.

+        sendResponse('guestCanAccessStorage');
+      // Messages from the options page containing test data
+      else if (message.hasOwnProperty('description')) {
+        if (message.description == 'onStorage') {

[not at google - send to devlin, 2014/07/21 16:30:43]

that said I don't think the outer message.hasOwnProperty(..) check is really
necessary; message.description will be undefined here, and therefore not ==
'onStorage'.

[ericzeng, 2014/07/21 17:52:39]

Done.

+          chrome.test.assertEq(message.expected, message.actual);
+          onStorage = true;
+        }
+        if (message.description == 'onSetCallback') {
+          chrome.test.assertEq(message.expected, message.actual);
+          onSetCallback = true;
+        }
+      }
+
+      if (onStorage && onSetCallback) {
+        document.body.removeChild(extensionoptions);
+        done();
+      }
+    });
+
+    var extensionoptions = document.createElement('extensionoptions');
+    extensionoptions.setAttribute('extension', chrome.runtime.id);
+    document.body.appendChild(extensionoptions);
+  }
+]);