Initial implementation of the <extensionoptions> GuestView tag

chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This script is opened inside a <extensionoptions> guest view. To confirm that
+// it has been successfully created, it adds {pass: true} to every extension
+// Window and broadcasts a message to the extension using runtime.sendMessage().
+chrome.extension.getViews().forEach(function(view) {
+  view.pass = true;
+});
+chrome.runtime.sendMessage('hi');

[not at google - send to devlin, 2014/07/18 22:59:34]

it's a bit odd to see these 2 tests intermingled here, but separate in test.js.
how about this design:

chrome.runtime.sendMessage('ready', function(command) {
  switch (test) {
    case 'canCreateExtensionOptionsGuest':
      // the chrome.extension.getViews() stuff.
      chrome.runtime.sendMessage('done');
      break;

    case 'guestCanAccessStorage':
      // similar to the chrome.storage stuff. 
  }
});

and then the test listens for that 'ready' message each time, sends the test
name, coordinates with the test to know when it's done (whether that be through
a 'done' message or other).

[ericzeng, 2014/07/19 00:43:44]

Done.

+
+// To test access to privileged APIs, the guest attempts to write to local
+// storage, and both the embedder and guest check if the write succeeded.
+var passed = chrome.test.callbackPass;
+
+chrome.test.listenOnce(chrome.storage.onChanged, function(change) {
+  chrome.test.assertEq(42, change.test.newValue);
+});
+
+chrome.storage.local.set({'test': 42}, passed(function() {

[not at google - send to devlin, 2014/07/18 22:59:34]

be careful here actually - this options page runs in a different context than
the test runner, and chrome.test.callbackPass automatically calls
chrome.test.pass when it's done. that means you'll get multiple test-passing
messages and undefined results.

you should try to make all of the test assertions happen in the test runner, so
here, send back to the test runner whether it was successful or not.

[ericzeng, 2014/07/19 00:43:44]

What about using chrome.test.callback instead?

[not at google - send to devlin, 2014/07/19 01:34:10]

I think that has the same problem:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...

which is callbackAdded, and has:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...

+  chrome.storage.local.get('test', passed(function(storage) {
+    chrome.test.assertEq(42, storage.test);
+  }));
+}));