Initial implementation of the <extensionoptions> GuestView tag

chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
 
 #include "base/command_line.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 220 matching lines @@
   source_map->RegisterSource("windowControls", IDR_WINDOW_CONTROLS_JS);
 
   // Custom types sources.
   source_map->RegisterSource("ChromeSetting", IDR_CHROME_SETTING_JS);
   source_map->RegisterSource("ContentSetting", IDR_CONTENT_SETTING_JS);
   source_map->RegisterSource("ChromeDirectSetting",
                              IDR_CHROME_DIRECT_SETTING_JS);
 
   // Platform app sources that are not API-specific..
   source_map->RegisterSource("appView", IDR_APP_VIEW_JS);
+  source_map->RegisterSource("extensionOptions", IDR_EXTENSION_OPTIONS_JS);
   source_map->RegisterSource("tagWatcher", IDR_TAG_WATCHER_JS);
   source_map->RegisterSource("webViewInternal",
                              IDR_WEB_VIEW_INTERNAL_CUSTOM_BINDINGS_JS);
   // Note: webView not webview so that this doesn't interfere with the
   // chrome.webview API bindings.
   source_map->RegisterSource("webView", IDR_WEB_VIEW_JS);
   source_map->RegisterSource("webViewEvents", IDR_WEB_VIEW_EVENTS_JS);
   source_map->RegisterSource("webViewExperimental",
                              IDR_WEB_VIEW_EXPERIMENTAL_JS);
   source_map->RegisterSource("webViewRequest",
                              IDR_WEB_VIEW_REQUEST_CUSTOM_BINDINGS_JS);
   source_map->RegisterSource("denyAppView", IDR_APP_VIEW_DENY_JS);
+  source_map->RegisterSource("denyExtensionOptions",

[not at google - send to devlin, 2014/07/08 15:43:39]

I don't think we need this "deny" logic. As I understand it that's to provide a
friendly surface for webview/appview to print a message like "you need to
request the web/appview permission to use the tag" but we don't actually need
that in the long term, so not much point adding code for it now.

[ericzeng, 2014/07/08 18:10:48]

Done.

+                             IDR_EXTENSION_OPTIONS_DENY_JS);
   source_map->RegisterSource("denyWebView", IDR_WEB_VIEW_DENY_JS);
   source_map->RegisterSource("injectAppTitlebar", IDR_INJECT_APP_TITLEBAR_JS);
 }
 
 void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules(
     extensions::ModuleSystem* module_system,
     const extensions::Extension* extension,
     extensions::Feature::Context context_type,
     bool is_within_platform_app) {
   // TODO(kalman, fsamuel): Eagerly calling Require on context startup is
@@ skipping 39 matching lines @@
     }
   }
 
   if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT) {
     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAppView) &&
         extension->permissions_data()->HasAPIPermission(
             extensions::APIPermission::kAppView)) {
       module_system->Require("appView");
     } else {
       module_system->Require("denyAppView");
     }

[not at google - send to devlin, 2014/07/08 15:43:39]

you might as well add some observable behaviour for all of this; how about
checking the command line flag + permission here, then Requiring that module you
added? same as appview basically, without the "deny" part.

that should also let you write some kind of test.

Fady, what's a reasonable minimal browser test for this stuff? maybe add a test
which
- given extension A and B
- loads extension A with an <extensionoptions> tag for extension B in its
options page
- checks that extension B has its options page open by sending a message to its
background page and using chrome.extension.getViews()

devlin or I can help you with that today. a quick search through the code for a
simple test that might be a good starting point:

test runner:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

extension with options page:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...

[Fady Samuel, 2014/07/08 15:46:48]

I will be sending you the following for review shortly :-) It includes a browser
test.

https://codereview.chromium.org/354483004/

   }
 }
 
 void ChromeExtensionsDispatcherDelegate::OnActiveExtensionsUpdated(
     const std::set<std::string>& extension_ids) {
   // In single-process mode, the browser process reports the active extensions.
   if (CommandLine::ForCurrentProcess()->HasSwitch(::switches::kSingleProcess))
     return;
   crash_keys::SetActiveExtensions(extension_ids);
 }
@@ skipping 43 matching lines @@
       new extensions::PermissionSet(extensions::APIPermissionSet(),
                                     extensions::ManifestPermissionSet(),
                                     origin_set,
                                     extensions::URLPatternSet()));
 }
 
 void ChromeExtensionsDispatcherDelegate::HandleWebRequestAPIUsage(
     bool webrequest_used) {
   webrequest_used_ = webrequest_used;
 }