Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 378763002: Remove type_profiler dependency from the build target 'chrome' to re-enable clang_type_profiler=1. (Closed)

Created:
6 years, 5 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 5 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove type_profiler dependency from the build target 'chrome' to re-enable clang_type_profiler=1. BUG=391520 TBR=caitkp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281685

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix for a case which is NOT clang_type_profiler=1. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/chrome_exe.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Cait, Sorry, I'm adding a TBR .gyp change since I found that your change ...
6 years, 5 months ago (2014-07-08 05:18:38 UTC) #1
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 5 months ago (2014-07-08 05:21:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/378763002/60001
6 years, 5 months ago (2014-07-08 05:22:03 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 07:06:30 UTC) #4
commit-bot: I haz the power
Change committed as 281685
6 years, 5 months ago (2014-07-08 07:22:27 UTC) #5
Cait (Slow)
6 years, 5 months ago (2014-07-08 19:16:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698