Navigation transitions: Place transition page in same process as destination page.

content/browser/site_instance_impl.cc

Index: content/browser/site_instance_impl.cc
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index b6e6918c0a48d755b0ae631270858c440afd3cb0..2af044400a04846c896cb01e8a5909f6c7c73e89 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -261,6 +261,11 @@ bool SiteInstance::IsSameWebSite(BrowserContext* browser_context,
   if (!url1.is_valid() || !url2.is_valid())
     return false;
 
+  // If either url is just a blank page, we treat them as part of the same site.

[Charlie Reis, 2014/07/25 17:31:22]

Ah, we don't actually want this for navigating from about:blank to a normal URL,
since it's possible for one website to inject content into an about:blank popup
(via JavaScript) and then navigate it elsewhere.  It's only ok when going from a
normal URL to about:blank.

I still think this change makes sense for src -> dest, so perhaps we should
change the names of url1 and url2 to src_url and dest_url (here and in the .h
file), and add a mention of this behavior in the declaration comment in
site_instance.h.

[shatch, 2014/07/25 20:57:05]

Done.

+  GURL blank_page = GURL(url::kAboutBlankURL);
+  if (url1 == blank_page || url2 == blank_page)
+    return true;
+
   // If the schemes differ, they aren't part of the same site.
   if (url1.scheme() != url2.scheme())
     return false;