content/browser/frame_host/render_frame_host_impl.cc - Issue 378743002: Navigation transitions: Place transition page in same process as destination page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 378743002: Navigation transitions: Place transition page in same process as destination page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_delegate.h ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | content/browser/transition_request_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index f7f959e201905f974da72117752bd8f7bc42d220..ddebdd6d0175d4aa7a284fd07ff73fce7b41b254 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -532,13 +532,16 @@ void RenderFrameHostImpl::OnCrossSiteResponse(

void RenderFrameHostImpl::OnDeferredAfterResponseStarted(

const GlobalRequestID& global_request_id) {

+ GURL transition_url =

+ TransitionRequestManager::GetInstance()->CreateTransitionURL();

frame_tree_node_->render_manager()->OnDeferredAfterResponseStarted(

- global_request_id, this);

+ global_request_id, this, transition_url);

if (GetParent() || !delegate_->WillHandleDeferAfterResponseStarted())

frame_tree_node_->render_manager()->ResumeResponseDeferredAtStart();

else

- delegate_->DidDeferAfterResponseStarted();

+ delegate_->DidDeferAfterResponseStarted(transition_url);

}

void RenderFrameHostImpl::SwapOut(RenderFrameProxyHost* proxy) {