Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 37873003: [PDF] Add unpremultiply support and a GM (try5) (Closed)

Created:
7 years, 2 months ago by vandebo (ex-Chrome)
Modified:
7 years, 1 month ago
Reviewers:
edisonn
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

[PDF] Add unpremultiply support and a GM (try5) This is a resubmit of https://codereview.chromium.org/22831039 which was reverted because it causes issues on Windows. BUG=chromium:175548 R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=11945

Patch Set 1 #

Patch Set 2 : Work around win issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -2 lines) Patch
A gm/bitmappremul.cpp View 1 1 chunk +133 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 2 chunks +162 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vandebo (ex-Chrome)
Yet another try on this change. The delta in patch set 2 made the gm ...
7 years, 1 month ago (2013-10-24 15:15:32 UTC) #1
edisonn
LGTM
7 years, 1 month ago (2013-10-24 15:17:34 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-10-24 15:18:23 UTC) #3
vandebo (ex-Chrome)
7 years, 1 month ago (2013-10-24 15:20:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698