Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 378713002: Added an option to run bisect-builds.py from git checkout so that 'Downloading list of know… (Closed)

Created:
6 years, 5 months ago by pshenoy
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, anantha, lushnikov
Project:
chromium
Visibility:
Public.

Description

Added an option (--use-local-repo) to run bisect-builds.py from git checkout so that 'Downloading list of known revisions' step is faster. If the script is run with --use-local-repo option, it will use "git svn find-rev <SHA1>" command to convert git hash to svn revision. This method is significantly faster than running the script without git checkout. Eg: Command to run: time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64 --use-local-repo Output: real 5m16.089s user 3m50.326s sys 1m1.190s time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64 Output: real 10m51.194s user 0m10.248s sys 0m1.419s BUG=390547 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281936

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
M tools/bisect-builds.py View 1 2 9 chunks +58 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pshenoy
6 years, 5 months ago (2014-07-07 22:42:29 UTC) #1
Robert Sesek
I don't think this is a good switch name, given the upcoming transition to git. ...
6 years, 5 months ago (2014-07-08 12:58:57 UTC) #2
pshenoy
Please take a look.
6 years, 5 months ago (2014-07-08 16:48:04 UTC) #3
Robert Sesek
https://codereview.chromium.org/378713002/diff/20001/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/378713002/diff/20001/tools/bisect-builds.py#newcode100 tools/bisect-builds.py:100: self.use_local_repo = use_local_repo nit: blank line before and a ...
6 years, 5 months ago (2014-07-08 18:52:58 UTC) #4
pshenoy
https://codereview.chromium.org/378713002/diff/20001/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/378713002/diff/20001/tools/bisect-builds.py#newcode100 tools/bisect-builds.py:100: self.use_local_repo = use_local_repo On 2014/07/08 18:52:58, rsesek wrote: > ...
6 years, 5 months ago (2014-07-08 19:58:19 UTC) #5
Robert Sesek
LGTM
6 years, 5 months ago (2014-07-08 21:06:15 UTC) #6
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 5 months ago (2014-07-08 21:23:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/378713002/40001
6 years, 5 months ago (2014-07-08 21:25:59 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:45:54 UTC) #9
Message was sent while issue was closed.
Change committed as 281936

Powered by Google App Engine
This is Rietveld 408576698