Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 378673002: [Ozone] Adding display related IPC messages (Closed)

Created:
6 years, 5 months ago by dnicoara
Modified:
6 years, 5 months ago
Reviewers:
kenrb, Daniel Erat, spang
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

[Ozone] Adding display related IPC messages These messages allow requesting display updates and performing basic display configuration. BUG=377497 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282022

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M ui/display/types/display_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
A ui/ozone/common/gpu/ozone_gpu_message_params.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ui/ozone/common/gpu/ozone_gpu_message_params.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 1 2 3 3 chunks +54 lines, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
spang
https://codereview.chromium.org/378673002/diff/20001/ui/ozone/common/gpu/ozone_gpu_messages.h File ui/ozone/common/gpu/ozone_gpu_messages.h (right): https://codereview.chromium.org/378673002/diff/20001/ui/ozone/common/gpu/ozone_gpu_messages.h#newcode54 ui/ozone/common/gpu/ozone_gpu_messages.h:54: // Cursor messages. It's not obvious which header belongs ...
6 years, 5 months ago (2014-07-08 14:09:39 UTC) #1
dnicoara
https://codereview.chromium.org/378673002/diff/20001/ui/ozone/common/gpu/ozone_gpu_messages.h File ui/ozone/common/gpu/ozone_gpu_messages.h (right): https://codereview.chromium.org/378673002/diff/20001/ui/ozone/common/gpu/ozone_gpu_messages.h#newcode54 ui/ozone/common/gpu/ozone_gpu_messages.h:54: // Cursor messages. On 2014/07/08 14:09:38, spang wrote: > ...
6 years, 5 months ago (2014-07-08 14:25:15 UTC) #2
dnicoara
Adding kenrb@ for IPC message review and derat@ for ui/display changes.
6 years, 5 months ago (2014-07-08 17:38:21 UTC) #3
Daniel Erat
lgtm for ui/display
6 years, 5 months ago (2014-07-08 17:41:03 UTC) #4
spang
lgtm
6 years, 5 months ago (2014-07-08 18:34:18 UTC) #5
kenrb
ipc lgtm
6 years, 5 months ago (2014-07-08 19:46:54 UTC) #6
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 5 months ago (2014-07-08 20:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/378673002/60001
6 years, 5 months ago (2014-07-08 20:16:17 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 22:59:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 02:45:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/46936)
6 years, 5 months ago (2014-07-09 02:45:34 UTC) #11
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 5 months ago (2014-07-09 13:18:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/378673002/60001
6 years, 5 months ago (2014-07-09 13:19:51 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 13:22:27 UTC) #14
Message was sent while issue was closed. 
Change committed as 282022

Powered by Google App Engine
This is Rietveld 408576698