Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 378653002: GN: Move mock_pref_change_callback.h to the correct section. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Move mock_pref_change_callback.h to the correct section. This resolves the following 'gn check' error: ERROR at //base/prefs/mock_pref_change_callback.cc:5:11: Include not allowed. #include "base/prefs/mock_pref_change_callback.h" ^------------------------------------- It is not in any dependency of //base:prefs_test_support The include file is in the target(s): //base:base_unittests which should somehow be reachable from //base:prefs_test_support Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
I'm not a base/ expert, but I don't see why this shouldn't just be in ...
6 years, 5 months ago (2014-07-07 21:04:07 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-08 21:17:58 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-09 13:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/378653002/1
6 years, 5 months ago (2014-07-09 13:16:38 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 15:15:43 UTC) #5
Message was sent while issue was closed.
Change committed as 282042

Powered by Google App Engine
This is Rietveld 408576698