Upstream support for basic Http authentication.

Upstream support for basic Http authentication.

The only piece missing was hooking up the UI from the internal repo. Do
that and remove dependency on Tab.

CQ_TRYBOTS=tryserver.chromium:android_aosp,android_clang_dbg,android_dbg

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281800

[Yaron, 2014-07-07 20:42:55]

https://codereview.chromium.org/378633002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java
(right):

https://codereview.chromium.org/378633002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java:26: public
class LoginPrompt implements ChromeHttpAuthHandler.AutofillObserver {
This was HttpAuthDialog in the internal tree. I renamed to match the native
counterpart.

[David Trainor- moved to gerrit, 2014-07-07 21:00:42]

lgtm

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
File chrome/android/java/res/layout/http_auth_dialog.xml (right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/res/layout/http_auth_dialog.xml:2: <!-- Copyright (c) 2011
The Chromium Authors. All rights reserved.
2014?

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java
(right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java:1: //
Copyright 2011 The Chromium Authors. All rights reserved.
2014

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java:65: mDialog
= new AlertDialog.Builder(mContext)
Do we need the dismiss callback?

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/browser/ui...
File chrome/browser/ui/android/chrome_http_auth_handler.h (right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/browser/ui...
chrome/browser/ui/android/chrome_http_auth_handler.h:50:
base::android::ScopedJavaLocalRef<jstring> GetMessageTitle(
Do we still need most of these?

[Yaron, 2014-07-08 00:22:25]

thanks for review

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
File chrome/android/java/res/layout/http_auth_dialog.xml (right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/res/layout/http_auth_dialog.xml:2: <!-- Copyright (c) 2011
The Chromium Authors. All rights reserved.
On 2014/07/07 21:00:41, David Trainor wrote:
> 2014?

Done.

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java
(right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java:1: //
Copyright 2011 The Chromium Authors. All rights reserved.
On 2014/07/07 21:00:42, David Trainor wrote:
> 2014

Done.

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java:65: mDialog
= new AlertDialog.Builder(mContext)
On 2014/07/07 21:00:41, David Trainor wrote:
> Do we need the dismiss callback?

I just copied the downstream one over. But I don't really see how it's possible

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/browser/ui...
File chrome/browser/ui/android/chrome_http_auth_handler.h (right):

https://chromiumcodereview.appspot.com/378633002/diff/40001/chrome/browser/ui...
chrome/browser/ui/android/chrome_http_auth_handler.h:50:
base::android::ScopedJavaLocalRef<jstring> GetMessageTitle(
On 2014/07/07 21:00:42, David Trainor wrote:
> Do we still need most of these?

Ya. I decided it's a separate change to switch to java resources.

[Yaron, 2014-07-08 00:31:08]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:33:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yfriedman@chromium.org/378633002/60001

[commit-bot: I haz the power, 2014-07-08 01:09:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[commit-bot: I haz the power, 2014-07-08 01:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 01:52:12]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[Yaron, 2014-07-08 15:52:12]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-07-08 15:53:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yfriedman@chromium.org/378633002/60001

[commit-bot: I haz the power, 2014-07-08 19:55:10]

Change committed as 281800