Skip to enter the fullscreen automatically when hole-punching is enabled.

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
@@ skipping 305 matching lines @@
 
   if (fullscreen_player_id_ != -1) {
     // TODO(qinmin): Determine the correct error code we should report to WMPA.
     OnError(player_id, MediaPlayerAndroid::MEDIA_ERROR_DECODE);
     return;
   }
 
   Send(new MediaPlayerMsg_RequestFullscreen(RoutingID(), player_id));
 }
 
+bool
+BrowserMediaPlayerManager::ShouldUseVideoOverlayForEmbeddedEncryptedVideo() {
+  RendererPreferences* prefs = web_contents_->GetMutableRendererPrefs();
+  return prefs->use_video_overlay_for_embedded_encrypted_video;

[xhwang, 2014/07/08 16:23:43]

Is this setting VIDEO_HOLE specific? 

If yes, this setting and this code isn't guarded by VIDEO_HOLE ifdef. Actually
the render side ShouldUseVideoOverlayForEmbeddedEncryptedVideo() code is guarded
by VIDEO_HOLE ifdef.

If no, you need to update the CL description to make this CL not VIDEO_HOLE
specific.

[ycheo (away), 2014/07/09 01:18:07]

Actually, the setting exists regardless of VIDEO_HOLE, but the usage is limited
to VIDEO_HOLE.
I didn't guard this because it makes that the condition in medio_source_player
looks ugly.
But, as you said, the function is only for the VIDEO_HOLE.
I think it would be better to guard it.
 

+}
+
 #if defined(VIDEO_HOLE)
 void BrowserMediaPlayerManager::AttachExternalVideoSurface(int player_id,
                                                            jobject surface) {
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player) {
     player->SetVideoSurface(
         gfx::ScopedJavaSurface::AcquireExternalSurface(surface));
   }
 }
 
@@ skipping 232 matching lines @@
 #if defined(VIDEO_HOLE)
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player && player->IsSurfaceInUse())
     return;
   if (external_video_surface_container_)
     external_video_surface_container_->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 }  // namespace content