[Athena] Extract Chrome OS authentication stack

[Athena] Extract Chrome OS authentication stack
Move Key/User context

BUG=387613
TBR=stevenjb@chromium.org
TBR=davemoore@chromium.org
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282126

[Denis Kuznetsov (DE-MUC), 2014-07-07 16:38:14]

This is just a move of key/user_context classes + extracting user name constants
to separate file.

Nikita for main review.

+davemoore as owner of most files.
+stevenjb for
  chrome/browser/extensions/api/networking_private/
  chrome/browser/ui/webui/options/chromeos/
+darin for
  chrome/browser/extensions/
  chrome/browser/invalidation/
  chrome/browser/policy/cloud/
  chrome/browser/supervised_user/chromeos/

[stevenjb, 2014-07-07 19:36:08]

Hooray! rubber-stamp owner lgtm

[darin (slow to review), 2014-07-07 20:18:36]

LGTM

[Nikita (slow), 2014-07-07 21:05:40]

lgtm

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
(left):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc:16:
#include "chrome/browser/chromeos/login/users/user_manager.h"
This include should be returned back since there're UserManager::Get() calls.
user_manager_impl.h should be removed.

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File
chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc
(left):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc:9:
#include "chrome/browser/chromeos/login/users/user_manager.h"
Still needed for chromeos::UserManager::Get()

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/auth/parallel_authenticator.cc (right):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/auth/parallel_authenticator.cc:13: 
nit: drop empty line

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/auth/parallel_authenticator.cc:33: using
content::BrowserThread;
nit: insert empty line

[Denis Kuznetsov (DE-MUC), 2014-07-08 11:08:28]

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
(left):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc:16:
#include "chrome/browser/chromeos/login/users/user_manager.h"
On 2014/07/07 21:05:40, Nikita Kostylev wrote:
> This include should be returned back since there're UserManager::Get() calls.
> user_manager_impl.h should be removed.

Done.

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File
chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc
(left):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc:9:
#include "chrome/browser/chromeos/login/users/user_manager.h"
On 2014/07/07 21:05:40, Nikita Kostylev wrote:
> Still needed for chromeos::UserManager::Get()

Done.

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/auth/parallel_authenticator.cc (right):

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/auth/parallel_authenticator.cc:13: 
On 2014/07/07 21:05:40, Nikita Kostylev wrote:
> nit: drop empty line

Done.

https://chromiumcodereview.appspot.com/378513005/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/auth/parallel_authenticator.cc:33: using
content::BrowserThread;
On 2014/07/07 21:05:40, Nikita Kostylev wrote:
> nit: insert empty line

Done.

[Denis Kuznetsov (DE-MUC), 2014-07-08 11:08:34]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-08 11:09:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/378513005/20001

[commit-bot: I haz the power, 2014-07-08 13:01:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-07-08 13:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 13:06:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Nikita (slow), 2014-07-09 12:45:15]

As it turns out there're several lint errors like headers not sorted or missing
empty line at the end of file.

[Denis Kuznetsov (DE-MUC), 2014-07-09 13:24:40]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-09 13:25:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/378513005/40001

[Denis Kuznetsov (DE-MUC), 2014-07-09 14:19:57]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:20:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/378513005/60001

[Denis Kuznetsov (DE-MUC), 2014-07-09 15:32:59]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-09 15:33:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/378513005/80001

[commit-bot: I haz the power, 2014-07-09 19:08:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 21:23:03]

Change committed as 282126