Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 378513002: Reland^3 r22105 "Remove static initializer from isolate" (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland^3 r22105 "Remove static initializer from isolate" This time: When accessing the isolate from the sampler signal handler, don't try to take the global lock. A sampler should only be active if there is already an isolate on that thread, so we don't need to check whether the TLS key is already created. BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M src/isolate.h View 6 chunks +15 lines, -8 lines 0 comments Download
M src/isolate.cc View 6 chunks +10 lines, -26 lines 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/check-static-initializers.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-07 10:00:05 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-07 10:21:49 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-07 10:56:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698