src/arm64/assembler-arm64-inl.h - Issue 378503003: ARM64: Use UntagSmi helpers and clean up assertions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/assembler-arm64-inl.h

Issue 378503003: ARM64: Use UntagSmi helpers and clean up assertions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Replace one '32' with 'kWRegSizeInBits'. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/assembler-arm64-inl.h

diff --git a/src/arm64/assembler-arm64-inl.h b/src/arm64/assembler-arm64-inl.h

index 444f2c4a9455316605d00da9d61a8f2f86ef2fca..960fe63fa2c7d6683db053e80995022413fb2944 100644

--- a/src/arm64/assembler-arm64-inl.h

+++ b/src/arm64/assembler-arm64-inl.h

@@ -430,12 +430,14 @@ unsigned Operand::shift_amount() const {

Operand Operand::UntagSmi(Register smi) {

+ STATIC_ASSERT((kSmiShift + kSmiValueSize) == kXRegSizeInBits);

ASSERT(smi.Is64Bits());

return Operand(smi, ASR, kSmiShift);

}

Operand Operand::UntagSmiAndScale(Register smi, int scale) {

+ STATIC_ASSERT((kSmiShift + kSmiValueSize) == kXRegSizeInBits);

ASSERT(smi.Is64Bits());

ASSERT((scale >= 0) && (scale <= (64 - kSmiValueSize)));

if (scale > kSmiShift) {

« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »