Issue 378503003: ARM64: Use UntagSmi helpers and clean up assertions.

Issue 378503003: ARM64: Use UntagSmi helpers and clean up assertions. (Closed)

Created:
6 years, 5 months ago by jbramley

Modified:
6 years, 5 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

ARM64: Use UntagSmi helpers and clean up assertions. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22247

Patch Set 2 : Replace one '32' with 'kWRegSizeInBits'. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -26 lines)			Patch
M	src/arm64/assembler-arm64-inl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm64/builtins-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	src/arm64/debug-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1	7 chunks	+7 lines, -11 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64-inl.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/378503003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/378503003/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode5405 src/arm64/lithium-codegen-arm64.cc:5405: STATIC_ASSERT((kSmiValueSize == 32) && (kSmiTag == 0)); kSmiValueSize ...

6 years, 5 months ago (2014-07-07 12:00:54 UTC) #2

jbramley

https://codereview.chromium.org/378503003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/378503003/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode5405 src/arm64/lithium-codegen-arm64.cc:5405: STATIC_ASSERT((kSmiValueSize == 32) && (kSmiTag == 0)); On 2014/07/07 ...

6 years, 5 months ago (2014-07-07 12:13:37 UTC) #3

jbramley

6 years, 5 months ago (2014-07-07 13:58:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22247 (presubmit successful).

Expand Messages | Collapse Messages