Issue 378473002: [ServiceWorker] Add wasFetchedViaServiceWorker flag to WebURLResponse and ResourceResponse.

Issue 378473002: [ServiceWorker] Add wasFetchedViaServiceWorker flag to WebURLResponse and ResourceResponse. (Closed)

Created:
6 years, 5 months ago by horo

Modified:
6 years, 5 months ago

Reviewers:
tyoshino (SeeGerritForStatus), jochen (gone - plz use gerrit), Mike West

CC:
abarth-chromium, blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

[ServiceWorker] Add wasFetchedViaServiceWorker flag to WebURLResponse and ResourceResponse. If the request was fetched via a ServiceWorker, the URL of the response could be different from the URL of the original request. So, we need to check the flag and the response URL in the ResourceFetcher::didReceiveResponse() and DocumentThreadableLoader::handleResponse() for CSP and CORS. This wasFetchedViaServiceWorker flag will be set in chromium side code. http://crrev.com/375513002 The check code itself will be added in another change. BUG=373120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177661

Patch Set 1 #

Total comments: 6

Patch Set 2 : incorporated tyoshino's comment #

Patch Set 3 : s/responce/response/ #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
M	Source/core/fetch/ResourceFetcher.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/loader/DocumentThreadableLoader.cpp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/platform/exported/WebURLResponse.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/platform/network/ResourceResponse.h	View	1	4 chunks	+8 lines, -0 lines	0 comments	Download
M	Source/platform/network/ResourceResponse.cpp	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	public/platform/WebURLResponse.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

lgtm https://codereview.chromium.org/378473002/diff/1/Source/platform/network/ResourceResponse.h File Source/platform/network/ResourceResponse.h (right): https://codereview.chromium.org/378473002/diff/1/Source/platform/network/ResourceResponse.h#newcode191 Source/platform/network/ResourceResponse.h:191: static bool compare(const ResourceResponse&, const ResourceResponse&); Could you ...

6 years, 5 months ago (2014-07-07 06:41:19 UTC) #2

horo

https://codereview.chromium.org/378473002/diff/1/Source/platform/network/ResourceResponse.h File Source/platform/network/ResourceResponse.h (right): https://codereview.chromium.org/378473002/diff/1/Source/platform/network/ResourceResponse.h#newcode191 Source/platform/network/ResourceResponse.h:191: static bool compare(const ResourceResponse&, const ResourceResponse&); On 2014/07/07 06:41:19, ...

6 years, 5 months ago (2014-07-07 06:52:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/378473002/40001

6 years, 5 months ago (2014-07-08 09:41:20 UTC) #7

Mike West

On 2014/07/08 at 09:41:20, commit-bot wrote: > CQ is trying da patch. Follow status at ...

6 years, 5 months ago (2014-07-08 10:40:14 UTC) #8

Message was sent while issue was closed.

Change committed as 177661

Expand Messages | Collapse Messages