Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: content/public/browser/storage_partition.h

Issue 37843003: BrowsingDataRemover, (re)use StoragePartition deletion code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase @tott. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/storage_partition.h
diff --git a/content/public/browser/storage_partition.h b/content/public/browser/storage_partition.h
index b30ca426f83f0a3a7435160d67f6f73543c25620..579ccbcbb448ed77f6c7b60000074a3d9d0dc758 100644
--- a/content/public/browser/storage_partition.h
+++ b/content/public/browser/storage_partition.h
@@ -26,6 +26,7 @@ class URLRequestContextGetter;
namespace quota {
class QuotaManager;
+class SpecialStoragePolicy;
}
namespace webkit_database {
@@ -97,19 +98,26 @@ class StoragePartition {
const GURL& storage_origin,
net::URLRequestContextGetter* rq_context) = 0;
- // Similar to ClearDataForOrigin(), but deletes all data out of the
- // StoragePartition rather than just the data related to this origin.
- virtual void ClearDataForUnboundedRange(uint32 remove_mask,
- uint32 quota_storage_remove_mask) = 0;
-
- // Similar to ClearDataForOrigin(), but deletes all the data out of the
- // StoragePartion from between the given |begin| and |end| dates rather
- // then just the data related to this origin.
- virtual void ClearDataForRange(uint32 remove_mask,
- uint32 quota_storage_remove_mask,
- const base::Time& begin,
- const base::Time& end,
- const base::Closure& callback) = 0;
+ // A callback type to check if a given origin matches a storage policy.
+ // Can be passed empty/null where used, which means the origin will always
+ // match.
+ typedef base::Callback<bool(const GURL&,
+ quota::SpecialStoragePolicy*)>
+ OriginMatcherFunction;
+
+ // Similar to ClearDataForOrigin().
+ // Deletes all data out fo the StoragePartition if |storage_origin| is NULL.
+ // |origin_matcher| is present if special storage policy is to be handled,
+ // otherwise the callback can be null (base::Callback::is_null() == true).
+ // |callback| is called when data deletion is done or at least the deletion is
+ // scheduled.
+ virtual void ClearData(uint32 remove_mask,
+ uint32 quota_storage_remove_mask,
+ const GURL* storage_origin,
+ const OriginMatcherFunction& origin_matcher,
+ const base::Time begin,
+ const base::Time end,
+ const base::Closure& callback) = 0;
protected:
virtual ~StoragePartition() {}

Powered by Google App Engine
This is Rietveld 408576698