Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 378423002: Treat sharded perf test timeouts as failures. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
starodub, jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Treat sharded perf test timeouts as failures. Previously, we'd halt running all further shards upon a timeout. Now, we'll just fail the one step and then continue. BUG=392490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/pylib/perf/test_runner.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 5 months ago (2014-07-09 22:17:26 UTC) #1
tonyg
6 years, 5 months ago (2014-07-10 00:23:00 UTC) #2
jbudorick
lgtm I think there's more to do on this ticket, though. I'll comment there.
6 years, 5 months ago (2014-07-10 00:38:11 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-10 00:39:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/378423002/1
6 years, 5 months ago (2014-07-10 00:41:24 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 04:00:11 UTC) #6
Message was sent while issue was closed.
Change committed as 282247

Powered by Google App Engine
This is Rietveld 408576698