Issue 378413002: Revert of Slim Skia down to just one murmur3 implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 378413002: Revert of Slim Skia down to just one murmur3 implementation. (Closed)

Created:
6 years, 5 months ago by mtklein

Modified:
6 years, 5 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Slim Skia down to just one murmur3 implementation. (https://codereview.chromium.org/376183004/) Reason for revert: Valgrind unhappy. skia:2735 Original issue's description: > Slim Skia down to just one murmur3 implementation. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1feac79203605c146671b731cb891b3c6eb49939

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -22 lines)			Patch
M	bench/FontCacheBench.cpp	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	src/core/SkChecksum.h	View	3 chunks	+7 lines, -16 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	3 chunks	+26 lines, -2 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	3 chunks	+27 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Slim Skia down to just one murmur3 implementation.

6 years, 5 months ago (2014-07-09 21:17:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/378413002/1

6 years, 5 months ago (2014-07-09 21:18:47 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-09 21:18:56 UTC) #3

Message was sent while issue was closed.

Change committed as 1feac79203605c146671b731cb891b3c6eb49939