Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 378403002: Remove deprecated FieldTrialHelper. (Closed)

Created:
6 years, 5 months ago by maxbogue
Modified:
6 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated FieldTrialHelper. The downstream dependencies in Chrome for Android have been updated to use org.chromium.base.FieldTrialList, so the old code can be removed. BUG=378035 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/FieldTrialHelper.java View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
maxbogue
6 years, 5 months ago (2014-07-09 20:21:31 UTC) #1
nyquist
Could you expand the description a bit to say why this now can be removed? ...
6 years, 5 months ago (2014-07-09 20:46:02 UTC) #2
maxbogue
On 2014/07/09 20:46:02, nyquist wrote: > Could you expand the description a bit to say ...
6 years, 5 months ago (2014-07-09 21:15:07 UTC) #3
nyquist
lgtm
6 years, 5 months ago (2014-07-09 21:46:46 UTC) #4
maxbogue
The CQ bit was checked by maxbogue@chromium.org
6 years, 5 months ago (2014-07-09 21:52:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maxbogue@chromium.org/378403002/1
6 years, 5 months ago (2014-07-09 21:55:28 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 04:26:25 UTC) #7
Message was sent while issue was closed.
Change committed as 282251

Powered by Google App Engine
This is Rietveld 408576698