Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 378363006: Revert of Turn on clang by default on linux, 3rd try. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
Reviewers:
awong1, Nico, Yuta Kitamura
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/379413002/) Reason for revert: NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed. http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging Original issue's description: > Turn on clang by default on linux, 3rd try. > > This is mostly to collect performance and size data for now, and to find out > if more bots need work. Unless things look really good, I'm going to revert > this by thursday morning (PDT). > > BUG=360311 > TBR=ajwong@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246 TBR=awong@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=360311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/clang/scripts/update.sh View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
horo
Created Revert of Turn on clang by default on linux, 3rd try.
6 years, 5 months ago (2014-07-10 07:25:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/378363006/1
6 years, 5 months ago (2014-07-10 07:25:45 UTC) #2
commit-bot: I haz the power
Change committed as 282265
6 years, 5 months ago (2014-07-10 07:27:25 UTC) #3
Yuta Kitamura
On 2014/07/10 07:27:25, I haz the power (commit-bot) wrote: > Change committed as 282265 It ...
6 years, 5 months ago (2014-07-10 07:30:23 UTC) #4
Yuta Kitamura
I'm going to revert this revert.
6 years, 5 months ago (2014-07-10 07:31:00 UTC) #5
Yuta Kitamura
6 years, 5 months ago (2014-07-10 07:34:16 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/382743002/ by yutak@chromium.org.

The reason for reverting is: This change should not have been reverted, since
it was easy to just disable these tests. thakis
explicitly requested "please ping thakis before
reverting it"..

Powered by Google App Engine
This is Rietveld 408576698