Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 378343004: Use Reflect on attributes in xml namespace (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
haraken, Inactive
CC:
blink-reviews, krit, arv+blink, fs, abarth-chromium, ed+blinkwatch_opera.com, blink-reviews-bindings_chromium.org, gyuyoung.kim_webkit.org, Inactive, f(malita), Stephen Chennney, kouhei+svg_chromium.org, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use Reflect on attributes in xml namespace Use Reflect on attributes in xml namespace, in order make this work teach v8_attributes.py about XMLNames namespace. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -43 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 1 chunk +10 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
PTAL.
6 years, 5 months ago (2014-07-09 17:32:29 UTC) #1
haraken
LGTM. Just to confirm: Adding [Reflect] won't change any existing web-exposed behavior, right? I'm asking ...
6 years, 5 months ago (2014-07-09 23:45:53 UTC) #2
rwlbuis
On 2014/07/09 23:45:53, haraken wrote: > LGTM. > > Just to confirm: Adding [Reflect] won't ...
6 years, 5 months ago (2014-07-10 11:50:53 UTC) #3
haraken
On 2014/07/10 11:50:53, rwlbuis wrote: > On 2014/07/09 23:45:53, haraken wrote: > > LGTM. > ...
6 years, 5 months ago (2014-07-10 11:57:43 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-10 14:32:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/378343004/1
6 years, 5 months ago (2014-07-10 14:33:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-10 15:41:45 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:25:40 UTC) #8
Message was sent while issue was closed.
Change committed as 177847

Powered by Google App Engine
This is Rietveld 408576698