chrome/browser/ui/views/toolbar/wrench_menu.cc - Issue 378333003: Allow menus to stay open during a child view's drag and drop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/wrench_menu.cc

Issue 378333003: Allow menus to stay open during a child view's drag and drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test Fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/wrench_menu.cc

diff --git a/chrome/browser/ui/views/toolbar/wrench_menu.cc b/chrome/browser/ui/views/toolbar/wrench_menu.cc

index 534db67150bf0cff8afbfcf61dc94df4b68451a5..026ea2a1783f90ed800e3a0858aa351d14b29584 100644

--- a/chrome/browser/ui/views/toolbar/wrench_menu.cc

+++ b/chrome/browser/ui/views/toolbar/wrench_menu.cc

@@ -1221,6 +1221,10 @@ void WrenchMenu::WillHideMenu(MenuItemView* menu) {

}

+bool WrenchMenu::ShouldCloseOnDragComplete() {

+ return false;

void WrenchMenu::BookmarkModelChanged() {

DCHECK(bookmark_menu_delegate_.get());

if (!bookmark_menu_delegate_->is_mutating_model())

« no previous file with comments | « chrome/browser/ui/views/toolbar/wrench_menu.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »