Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 378303002: [DevTools] Do not build most of chrome/browser/devtools on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GN and unittests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_debugger.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/BUILD.gn
diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn
index f7f0a83eef71ec397200c6874db6b4e75295d3fa..4af7b9eb7ad84b7c7f5ba3dd384a1728f8b6c116 100644
--- a/chrome/browser/devtools/BUILD.gn
+++ b/chrome/browser/devtools/BUILD.gn
@@ -19,42 +19,10 @@ action("devtools_protocol_constants") {
# GYP version: chrome/chrome_debugger.gypi:debugger
static_library("devtools") {
+ # Note: new sources and deps should be generally added in (!is_android) below.
sources = [
- "device/adb/adb_client_socket.cc",
- "device/adb/adb_client_socket.h",
- "device/adb/adb_device_info_query.cc",
- "device/adb/adb_device_info_query.h",
- "device/adb/adb_device_provider.cc",
- "device/adb/adb_device_provider.h",
- "device/android_device_manager.cc",
- "device/android_device_manager.h",
- "device/android_web_socket.cc",
- "device/devtools_android_bridge.cc",
- "device/devtools_android_bridge.h",
- "device/port_forwarding_controller.cc",
- "device/port_forwarding_controller.h",
- "device/self_device_provider.cc",
- "device/self_device_provider.h",
- "device/usb/android_rsa.cc",
- "device/usb/android_rsa.h",
- "device/usb/android_usb_device.cc",
- "device/usb/android_usb_device.h",
- "device/usb/android_usb_socket.cc",
- "device/usb/android_usb_socket.h",
- "device/usb/usb_device_provider.cc",
- "device/usb/usb_device_provider.h",
- "browser_list_tabcontents_provider.cc",
- "browser_list_tabcontents_provider.h",
"chrome_devtools_manager_delegate.cc",
"chrome_devtools_manager_delegate.h",
- "devtools_contents_resizing_strategy.cc",
- "devtools_contents_resizing_strategy.h",
- "devtools_embedder_message_dispatcher.cc",
- "devtools_embedder_message_dispatcher.h",
- "devtools_file_helper.cc",
- "devtools_file_helper.h",
- "devtools_file_system_indexer.cc",
- "devtools_file_system_indexer.h",
"devtools_network_conditions.cc",
"devtools_network_conditions.h",
"devtools_network_controller.cc",
@@ -66,19 +34,7 @@ static_library("devtools") {
"devtools_network_transaction_factory.cc",
"devtools_network_transaction_factory.h",
"devtools_protocol.cc",
- "devtools_protocol.h",
- "devtools_target_impl.cc",
- "devtools_target_impl.h",
- "devtools_targets_ui.cc",
- "devtools_targets_ui.h",
- "devtools_toggle_action.cc",
- "devtools_toggle_action.h",
- "devtools_ui_bindings.cc",
- "devtools_ui_bindings.h",
- "devtools_window.cc",
- "devtools_window.h",
- "remote_debugging_server.cc",
- "remote_debugging_server.h",
+ "devtools_protocol.h"
]
sources += get_target_outputs(":devtools_protocol_constants")
@@ -97,30 +53,69 @@ static_library("devtools") {
deps = [
":devtools_protocol_constants",
"//base",
- "//chrome:extra_resources",
- "//chrome:resources",
- "//chrome:strings",
- "//chrome/app/theme:theme_resources",
- "//chrome/common/extensions/api",
"//content/public/browser",
"//net",
- "//net:http_server",
- "//skia",
- "//third_party/icu",
- "//third_party/leveldatabase",
]
- if (is_android) {
- sources -= [
+
+ if (!is_android) {
+ deps += [
+ "//chrome:extra_resources",
+ "//chrome:resources",
+ "//chrome:strings",
+ "//chrome/app/theme:theme_resources",
+ "//chrome/common/extensions/api",
+ "//net:http_server",
+ "//skia",
+ "//third_party/icu",
+ "//third_party/leveldatabase",
+ "//third_party/libusb"
+ ]
+ sources += [
+ "device/adb/adb_client_socket.cc",
+ "device/adb/adb_client_socket.h",
+ "device/adb/adb_device_info_query.cc",
+ "device/adb/adb_device_info_query.h",
+ "device/adb/adb_device_provider.cc",
+ "device/adb/adb_device_provider.h",
+ "device/android_device_manager.cc",
+ "device/android_device_manager.h",
+ "device/android_web_socket.cc",
+ "device/devtools_android_bridge.cc",
+ "device/devtools_android_bridge.h",
+ "device/port_forwarding_controller.cc",
+ "device/port_forwarding_controller.h",
+ "device/self_device_provider.cc",
+ "device/self_device_provider.h",
"device/usb/android_rsa.cc",
+ "device/usb/android_rsa.h",
+ "device/usb/android_usb_device.cc",
+ "device/usb/android_usb_device.h",
+ "device/usb/android_usb_socket.cc",
+ "device/usb/android_usb_socket.h",
+ "device/usb/usb_device_provider.cc",
+ "device/usb/usb_device_provider.h",
"browser_list_tabcontents_provider.cc",
+ "browser_list_tabcontents_provider.h",
+ "devtools_contents_resizing_strategy.cc",
+ "devtools_contents_resizing_strategy.h",
+ "devtools_embedder_message_dispatcher.cc",
+ "devtools_embedder_message_dispatcher.h",
+ "devtools_file_helper.cc",
+ "devtools_file_helper.h",
"devtools_file_system_indexer.cc",
+ "devtools_file_system_indexer.h",
"devtools_target_impl.cc",
+ "devtools_target_impl.h",
+ "devtools_targets_ui.cc",
+ "devtools_targets_ui.h",
+ "devtools_toggle_action.cc",
+ "devtools_toggle_action.h",
"devtools_ui_bindings.cc",
+ "devtools_ui_bindings.h",
"devtools_window.cc",
- "devtools_window_base.cc",
+ "devtools_window.h",
"remote_debugging_server.cc",
+ "remote_debugging_server.h"
]
- } else {
- deps += [ "//third_party/libusb" ]
}
}
« no previous file with comments | « no previous file | chrome/chrome_debugger.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698