Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 378303002: [DevTools] Do not build most of chrome/browser/devtools on android. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not build most of chrome/browser/devtools on android. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282596

Patch Set 1 #

Patch Set 2 : GN and unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -121 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 3 chunks +55 lines, -60 lines 0 comments Download
M chrome/chrome_debugger.gypi View 2 chunks +52 lines, -61 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Could you please take a look?
6 years, 5 months ago (2014-07-10 09:38:32 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-10 10:57:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 11:15:45 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-11 08:38:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/378303002/20001
6 years, 5 months ago (2014-07-11 08:39:23 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 09:35:24 UTC) #6
Message was sent while issue was closed.
Change committed as 282596

Powered by Google App Engine
This is Rietveld 408576698